feat: listener add async function support#13
Open
kurten wants to merge 4 commits intonode-modules:masterfrom
kurten:master
Open
feat: listener add async function support#13kurten wants to merge 4 commits intonode-modules:masterfrom kurten:master
kurten wants to merge 4 commits intonode-modules:masterfrom
kurten:master
Conversation
gxcsoccer
reviewed
Apr 4, 2018
index.js
Outdated
| const ret = yield listener(...args); | ||
| if (is.promise(ret)) { | ||
| yield ret; | ||
| } |
Member
There was a problem hiding this comment.
这里要 generator 和 async 分开判断，async 不要包 co 了
Member
There was a problem hiding this comment.
没办法，包一层 async 的化就只处理下 catch 就好了
gxcsoccer
reviewed
Apr 4, 2018
package.json
Outdated
| { | ||
| "name": "sdk-base", | ||
| "version": "3.4.0", | ||
| "version": "3.4.1", |
Member
|
另外 ci 要搞过 |
Member
|
async 的用例在 node 6 下跑不了 |
Author
|
依赖了babel，能过node 6测试 |
gxcsoccer
reviewed
Apr 4, 2018
test/.setup.js
Outdated
| @@ -0,0 +1,3 @@ | |||
| 'use strict'; | |||
|
|
|||
| require('babel-register'); | |||
gxcsoccer
reviewed
Apr 4, 2018
| yield listener(...args); | ||
| }); | ||
| } | ||
| promise.catch(err => { |
Member
There was a problem hiding this comment.
removeListener 的时候也要支持下 async function
Author
|
已经修复 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rt
listener support async function